-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox: Email content sometimes lost when sending #31
Comments
More info: Affected clients
What's happeningIf the user tabs into the compose body from the subject box, then the If the user then uses the Markdown Here hotkey, this causes our WorkaroundClick in the body at least once before Markdown Toggling. Or right-click (use the Markdown Toggle context menu item, for example). Fixing itMy best/only idea so far is something like: if (focusedElem instanceof HTMLHtmlElement) {
focusedElem = focusedElem.ownerDocument.body;
} This feels kinda dirty and/or hacky and/or special-case-y. But I don't know another way of finding the focus (side note: I'll probably use that fix. But I'll think about it until tomorrow. If anyone has another idea, please let me know. |
There seems to already be a bug filed with Mozilla about this behaviour: |
Fixed in version 2.6.2 (which should clear Mozilla review in a week). |
Reproduction, maybe:
When viewing the DOM after the rendering, it appears that the
markdown-here-wrapper
is ending up as a direct child of thehtml
element, instead of thebody
element -- but the sig is staying in thebody
.I don't have any other info or insight into this right now, but I'll look into it soon. It's very bad.
The text was updated successfully, but these errors were encountered: