Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade linting capabilities #90

Merged
merged 1 commit into from
Dec 8, 2024
Merged

feat: upgrade linting capabilities #90

merged 1 commit into from
Dec 8, 2024

Conversation

adamalston
Copy link
Owner

Reference commits: f90b92d...9afc6d1


Debugging info related to dirname in CI:

console.log({
  dirname: _dirname,
  importMetaDirname: import.meta.dirname,
  equal: _dirname === import.meta.dirname,
  internalDirectories,
  rand: process.cwd(),
  meta: import.meta,
});

Node v18: https://github.com/adamalston/v2/actions/runs/12171967104/job/33949821164#step:5:9

{
  dirname: '/home/runner/work/v2/v2',
  importMetaDirname: undefined,
  equal: false,
  internalDirectories: [ 'App', '__mocks__', 'appearance', 'components', 'icons', 'types' ],
  rand: '/home/runner/work/v2/v2',
  meta: [Object: null prototype] {
    resolve: [Function: resolve],
    url: 'file:///home/runner/work/v2/v2/eslint.config.mjs?mtime=1733365136684'
  }
}

Node lts/*: https://github.com/adamalston/v2/actions/runs/12171967104/job/33949821386#step:5:9

{
  dirname: '/home/runner/work/v2/v2',
  importMetaDirname: '/home/runner/work/v2/v2',
  equal: true,
  internalDirectories: [ 'App', '__mocks__', 'appearance', 'components', 'icons', 'types' ],
  rand: '/home/runner/work/v2/v2',
  meta: [Object: null prototype] {
    dirname: '/home/runner/work/v2/v2',
    filename: '/home/runner/work/v2/v2/eslint.config.mjs',
    resolve: [Function: resolve],
    url: 'file:///home/runner/work/v2/v2/eslint.config.mjs?mtime=1733365136745'
  }
}

Closes #89

@adamalston adamalston merged commit 9cfa232 into main Dec 8, 2024
4 checks passed
@adamalston adamalston deleted the n/a-perfectionist branch December 8, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort imports via ESLint
1 participant