Made some property-getters within serializable classes public as othe…

[fgollas]

…rwise there was a deserialization issue (NullRefException) when integrating the nuget within a net48 project and deserializing a Model

[adamecr]

Hello @fgollas, these property-getters are intentionally private - the idea is to use them just by XML deserializer, but the parser access them using other properties with some logic:

• AllowedValues.Values instead of .Text
• DecisionTable.HitPolicy instead of .HitPolicySrc and .Aggregation instead of .AggregationSrc
• InformationRequirement.RequirementType and .Ref encapsulating .RequiredDecision and .RequiredInput

I'll try the case "nuget package with net48 project" (the test project use the project reference, so there might be a bit different behavior) later on to check for the exception and the root cause. If positive (meaning erroneous), I'll have to think a bit how to "mask" these source XML props

[adamecr]

first quick look - nuget package + netcore21 project works fine - tests passed. However nuget package + net 472 failed as described.
Will have a look on the deserialization. Frankly, I didn't work with "full" .net framework for a while :-)

Edit:
it seems that in net core, the XmlSerializer may be valid for deserialization only - may not have public getters. For net framework the check is both for readable and writable properties.

I can imagine using IXmlSerializable for AllowedValues class, but I don't like the idea for the others, at these are quite complex.

I'll keep digging, not quite happy with making the props public

[fgollas]

@adamecr: Thank you for investigating.

[adamecr]

@fgollas : finally I decided to move forward with IXmlSerializable and proxy classes where needed.
You can have a look in tst-pullreq1 branch - the first commit in branch (I have also added the net framework test project in the second commit and updated packages in the third one)

I'll do some more testing and publish the patch (merge to master + package) later on and then close this pull request.

[adamecr]

@fgollas - v0.1.1 released.
The issues has been fixed using different approach that in this PR (proxy classes instead of "unhiding" the getters), so closing this PR

[fgollas]

thanks alot! Works now for me. Reintegrated your version 0.1.1