Atomize namespace processing; Install full Sylius library to use as c…

…andidates.
adamelso · Jun 10, 2024 · 873f9ba · 873f9ba
1 parent 8251fdf
commit 873f9ba
Show file tree

Hide file tree

Showing 8 changed files with 154 additions and 54 deletions.
diff --git a/README.md b/README.md
@@ -1,2 +1,11 @@
-# transunit
+Transunit
+===
+
 Convert PhpSpec tests to PHPUnit
+
+Dependencies
+---
+
+ - nikic/php-parser
+ - symfony/finder
+ - symfony/filesystem
diff --git a/composer.json b/composer.json
@@ -2,13 +2,11 @@
     "require-dev": {
         "phpspec/phpspec": "*",
         "phpunit/phpunit": "*",
-        "sylius/addressing": "*",
+        "sylius/sylius": "^1.0",
         "phpspec/prophecy-phpunit": "^2.2"
     },
     "require": {
-        "nikic/php-parser": "*",
-        "symfony/finder": "*",
-        "symfony/filesystem": "^7.0"
+        "nikic/php-parser": "*"
     },
     "autoload": {
         "psr-4": {

diff --git a/lib/Transunit/Pass/GlobalTestSubjectInstancePass.php b/lib/Transunit/Pass/GlobalTestSubjectInstancePass.php
@@ -73,14 +73,29 @@ private function instantiateTestSubject(Node\Stmt\ClassMethod $node, string $sub
 
         foreach ($node->stmts as $stmt) {
             // Check if expression is a property assignment
-            if ($stmt instanceof Node\Stmt\Expression
-                && $stmt->expr instanceof Node\Expr\Assign
-                && $stmt->expr->var instanceof Node\Expr\PropertyFetch
-                && $stmt->expr->var->var instanceof Node\Expr\Variable
-                && $stmt->expr->var->var->name === 'this'
-            ) {
-                $collaboratorNames[$stmt->expr->var->name->name] = true;
+            if (! $stmt instanceof Node\Stmt\Expression) {
+                continue;
+            }
+
+            if (! $stmt->expr instanceof Node\Expr\Assign) {
+                continue;
+            }
+
+            if (! $stmt->expr->var instanceof Node\Expr\PropertyFetch) {
+                continue;
             }
+
+            if (! $stmt->expr->var->var instanceof Node\Expr\Variable) {
+                continue;
+            }
+
+            $collaboratorVariableName = $stmt->expr->var->var->name;
+
+            if ($collaboratorVariableName === 'this') {
+                continue;
+            }
+
+            $collaboratorNames[$collaboratorVariableName] = true;
         }
 
         $globalCollaborators = [];

diff --git a/lib/Transunit/Pass/ImportMockingLibraryPass.php b/lib/Transunit/Pass/ImportMockingLibraryPass.php
@@ -0,0 +1,48 @@
+<?php
+
+namespace Transunit\Pass;
+
+use PhpParser\Node;
+use PhpParser\Node\Name;
+use PhpParser\Node\Stmt\Namespace_;
+use PhpParser\NodeFinder;
+use Transunit\Pass;
+
+/**
+ * ```
+ * + use Prophecy\Prophecy\ObjectProphecy;
+ * + use Prophecy\PhpUnit\ProphecyTrait;
+ * + use PHPUnit\Framework\TestCase;
+ * ```
+ */
+class ImportMockingLibraryPass implements Pass
+{
+    public function find(NodeFinder $nodeFinder, $ast): array
+    {
+        return [$nodeFinder->findFirstInstanceOf($ast, Namespace_::class)];
+    }
+
+    public function rewrite(Node $node): void
+    {
+        if (!$node instanceof Namespace_) {
+            return;
+        }
+
+        $this->importMockingLibraryClasses($node);
+    }
+
+    private function importMockingLibraryClasses(Namespace_ $node): void
+    {
+        array_unshift($node->stmts, new Node\Stmt\Use_([
+            new Node\Stmt\UseUse(new Name('Prophecy\Prophecy\ObjectProphecy')),
+        ]));
+
+        array_unshift($node->stmts, new Node\Stmt\Use_([
+            new Node\Stmt\UseUse(new Name('Prophecy\PhpUnit\ProphecyTrait')),
+        ]));
+
+        array_unshift($node->stmts, new Node\Stmt\Use_([
+            new Node\Stmt\UseUse(new Name('PHPUnit\Framework\TestCase')),
+        ]));
+    }
+}
diff --git a/lib/Transunit/Pass/NamespacePass.php → ...Transunit/Pass/ImportSubjectClassPass.php b/lib/Transunit/Pass/NamespacePass.php → ...Transunit/Pass/ImportSubjectClassPass.php
@@ -8,7 +8,17 @@
 use PhpParser\NodeFinder;
 use Transunit\Pass;
 
-class NamespacePass implements Pass
+/**
+ * ```
+ *   namespace test\unit\Foo\Bar;
+ *
+ * + use Foo\Bar\TestSubject;
+ *
+ *   class TestSubjectSpec extends ObjectBehaviour
+ *   {
+ * ```
+ */
+class ImportSubjectClassPass implements Pass
 {
     public function find(NodeFinder $nodeFinder, $ast): array
     {
@@ -21,24 +31,7 @@ public function rewrite(Node $node): void
             return;
         }
 
-        $this->moveToNamespace($node);
         $this->importSubjectClass($node);
-        $this->importMockingLibraryClasses($node);
-    }
-
-    /**
-     * namespace tests\unit\Foo\Bar;
-     */
-    private function moveToNamespace(Namespace_ $node): void
-    {
-        $ns = $node->name->getParts();
-
-        if ($ns[0] === 'spec') {
-            array_shift($ns);
-            $ns = array_merge(['tests', 'unit'], $ns);
-        }
-
-        $node->name = new Name($ns);
     }
 
     /**
@@ -81,19 +74,4 @@ private function importSubjectClass(Namespace_ $node): void
 
         array_unshift($node->stmts, $use);
     }
-
-    private function importMockingLibraryClasses(Namespace_ $node): void
-    {
-        array_unshift($node->stmts, new Node\Stmt\Use_([
-            new Node\Stmt\UseUse(new Name('Prophecy\Prophecy\ObjectProphecy')),
-        ]));
-
-        array_unshift($node->stmts, new Node\Stmt\Use_([
-            new Node\Stmt\UseUse(new Name('Prophecy\PhpUnit\ProphecyTrait')),
-        ]));
-
-        array_unshift($node->stmts, new Node\Stmt\Use_([
-            new Node\Stmt\UseUse(new Name('PHPUnit\Framework\TestCase')),
-        ]));
-    }
 }
diff --git a/lib/Transunit/Pass/MoveNamespacePass.php b/lib/Transunit/Pass/MoveNamespacePass.php
@@ -0,0 +1,44 @@
+<?php
+
+namespace Transunit\Pass;
+
+use PhpParser\Node;
+use PhpParser\Node\Name;
+use PhpParser\Node\Stmt\Namespace_;
+use PhpParser\NodeFinder;
+use Transunit\Pass;
+
+/**
+ * ```
+ * - namespace spec\Foo\Bar;
+ * + namespace tests\unit\Foo\Bar;
+ * ```
+ */
+class MoveNamespacePass implements Pass
+{
+    public function find(NodeFinder $nodeFinder, $ast): array
+    {
+        return [$nodeFinder->findFirstInstanceOf($ast, Namespace_::class)];
+    }
+
+    public function rewrite(Node $node): void
+    {
+        if (!$node instanceof Namespace_) {
+            return;
+        }
+
+        $this->moveToNamespace($node);
+    }
+
+    private function moveToNamespace(Namespace_ $node): void
+    {
+        $ns = $node->name->getParts();
+
+        if ($ns[0] === 'spec') {
+            array_shift($ns);
+            $ns = array_merge(['tests', 'unit'], $ns);
+        }
+
+        $node->name = new Name($ns);
+    }
+}
diff --git a/lib/Transunit/Transunit.php b/lib/Transunit/Transunit.php
@@ -12,22 +12,27 @@
 
 class Transunit
 {
-    public static function run(string $path): void
+    public static function run(string $path, string $destination = 'var'): void
     {
-        $f = new Filesystem();
+        $fs = new Filesystem();
         $specs = (new Finder())->files()->in($path)->name('*Spec.php');
 
         $root = dirname(__DIR__, 2);
-        $exportDir = "{$root}/var";
-        $f->remove($exportDir);
-        $f->mkdir($exportDir);
+        $exportDir = "{$root}/{$destination}";
+
+        $fs->remove($exportDir);
+        $fs->mkdir($exportDir);
 
         foreach ($specs as $file) {
+            $relative = trim($fs->makePathRelative($file->getPath(), $path), DIRECTORY_SEPARATOR);
             $newFilename = substr($file->getBasename(), 0, -8) . 'Test.php';
+            $fullPathToNewTestFile = "{$exportDir}/{$relative}/{$newFilename}";
+
             $modifiedCode = self::processFile($file->getRealPath());
-            $fullPathToNewTestFile = "{$exportDir}/{$newFilename}";
-            $f->touch($fullPathToNewTestFile);
-            file_put_contents($fullPathToNewTestFile, $modifiedCode);
+
+            $fs->mkdir("{$exportDir}/{$relative}");
+            $fs->touch($fullPathToNewTestFile);
+            $fs->dumpFile($fullPathToNewTestFile, $modifiedCode);
         }
     }
 
@@ -49,7 +54,9 @@ private static function processFile(string $path): string
 
         $nodeFinder = new NodeFinder();
         $passes = [
-            new Pass\NamespacePass(),
+            new Pass\MoveNamespacePass(),
+            new Pass\ImportSubjectClassPass(),
+            new Pass\ImportMockingLibraryPass(),
             new Pass\ClassnamePass(),
             new Pass\GlobalCollaboratorPass(),
             new Pass\GlobalTestSubjectInstancePass(),

diff --git a/transunit.php b/transunit.php
@@ -4,5 +4,6 @@
 
 $args = $argv;
 array_shift($args);
+$args[0] = getcwd().'/'.$args[0];
 
 \Transunit\Transunit::run(...$args);