-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometric test whether ray intersects sphere #83
Geometric test whether ray intersects sphere #83
Conversation
There's a bit of syntax touching in there. Is that a PEP-8 formatter? Admittedly this library isn't PEP8 formatted, it originates from before I knew of it. I just haven't had a need to update it but I am happy to. However, it would be better if we could do a PEP8 separately. Apart from that, looks good. Thanks for including tests. |
Created #84 to cover syntax changes. |
Yes sure. Sorry for useless overriding of original format. |
Sorry been busy, hopefully I'll get some time to look soon. |
Sorry for very(!) late reply to this small issue. Branch should be clean now. |
Nice man, thanks for coming back and doing that =) |
We should add you to the contributors too. Is that ok with you to put your name in the authors section? |
Thanks man. Of course, would be nice. Just add me. |
Added this feature since I needed it myself for another project where I use Pyrr. Thought it makes sense to add it here.
Function return list of intersection points (possible 0 to 2) calculated via quadratic equation solver added to misc.