Render array elements in test output

[ursenzler]

When running these tests

    public class Foo
    {
        [Theory]
        [InlineData(new[] { "00:00-06:00" }, new[] { "05:45-10:00" }, new[] { "06:00-10:00" }, 4 * 60)]
        public void Theory(object[] a, object[] b, object[] c, int i)
        {    
        }

        [Scenario]
        [Example(new[] { "00:00-06:00" }, new[] { "05:45-10:00" }, new[] { "06:00-10:00" }, 4 * 60)]
        public void Scenario(object[] a, object[] b, object[] c, int i)
        {
        }
    }

the output looks like

Any idea, why the bare xunit test formats the arguments and the xbehave test doesn't?

[ursenzler]

btw, when replacing Example with InlineData, there is still no formatting when using xBehave.

[adamralph]

Interesting!

xbehave performs it's own rendering of the test names rather than using the rendering in xunit (due to supporting the generation of default values for method params). For the most part, ToString() is called on each argument but I guess xunit must be special casing arrays by calling ToString() for each element and rendering them in a square bracketed CSV. I'm sure we can just replicate this in xbehave easily enough.

[adamralph]

I guess we could also investigate what xunit does with other enumerable types and if there is any other special rendering we could also replicate it and expand the scope of this beyond just arrays.

[ursenzler]

@adamralph can you give me a pointer to where the rendering happens? I didn't find it :-(

[adamralph]

@ursenzler sure, here you go https://github.com/xbehave/xbehave.net/blob/30c9df9fe7f4736c54d68ef7e860facdf728e95e/src/Xbehave.2.Execution.desktop/ScenarioRunnerFactory.cs#L205

[ursenzler]

thanks. I'll try to integrate the xUnit magic into that method.

[adamralph]

Thank you!

On Thu, 3 Sep 2015 at 10:27 Urs Enzler [email protected] wrote:

thanks. I'll try to integrate the xUnit magic into that method.

—
Reply to this email directly or view it on GitHub
#267 (comment)
.

[ursenzler]

@adamralph how can I create a nuget package from the xBehave sources/binaries. Is there something in the repo or do I have to create it myself?

[adamralph]

@ursenzler if you build it using Rake it will produce the nugets in artifacts/bin/.

[ursenzler]

@adamralph ah, okay.

[adamralph]

That usually means the wrong version of albacore is being used. Did you use bundler to install the gems and invoke rake?

[ursenzler]

I went through all the steps in the "how to build" again and I can build now. thanks. Had some gem updates.

[ursenzler]

Unfortunately, the ArgumentFormatter used in xUnit is internal.

My suggestion:

1. make a pull request to xUnit to make ArgumentFormatter public
2. for now, duplicate the code in xBehave.
3. once the ArgumentFormatter is public, use it and remove duplication.

What do you think?

[ursenzler]

Prototype working:

[adamralph]

@ursenzler looks good!

I think your suggestion makes sense.

[adamralph]

So, it is indeed a little embarrassing that this hasn't been released yet. The reason was that 2.1 was always intended to be a release which added support for DNX/CoreCLR/dotnet/whatever-it's-called-this-month, in line with xunit 2.1, to keep the version numbers aligned. That work has been put on hold.

Given that the first xbehave release containing support for that nebulously named platform will be targeting some version of xunit > 2.1 (not to mention that keeping the xbehave and xunit minor version aligned for eternity probably isnt realistic anyway) I'm happy to push out 2.1 immediately, containing this feature. I'll do so ASAP.

/cc @ursenzler

[ursenzler]

woohoo!

[adamralph]

Thanks @ursenzler! Look out for your name in the release notes 🏆

https://www.nuget.org/packages/Xbehave/2.1.0
https://www.nuget.org/packages/Xbehave.Core/2.1.0
https://github.com/xbehave/xbehave.net/releases/tag/2.1.0
https://twitter.com/xbehavenet/status/725377198648098816