Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix identical file after replacement returns 0 changed files #62

Conversation

webstacker
Copy link

Relates to #61

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 661f2bb on webstacker:consistent-replace-behaviour-issue-61 into 5d8e7eb on adamreisnz:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 661f2bb on webstacker:consistent-replace-behaviour-issue-61 into 5d8e7eb on adamreisnz:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 661f2bb on webstacker:consistent-replace-behaviour-issue-61 into 5d8e7eb on adamreisnz:master.

@adamreisnz
Copy link
Owner

Thanks for the PR, I will take this into account and try to merge it for the upcoming 4.0 release. Can't merge it into the current major version as some people may rely on the current functionality.

@adamreisnz
Copy link
Owner

In 4.0.0, we return a results array for each file that was processed, along with a count of number of matches and number of replacements. That should cover the use case of #61 and allow you to figure out if any replacements were made and if a file was changed or not.

@adamreisnz adamreisnz closed this Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants