Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version number. #183

Merged
merged 1 commit into from
Feb 19, 2015
Merged

Bump version number. #183

merged 1 commit into from
Feb 19, 2015

Conversation

josephdburdick
Copy link
Contributor

This simply matches the .js file number with the release number to avoid confusion. Also, while version 1.6.2 is the latest version since last November the only version available on Bower is 1.6.1. I'm not sure which version addresses this because of the version mismatch but:

When I download your plugin from Bower I get a .bower.json file that lacks a "main" key which means when trying to use Browserify it can't find the actual JS file. The solution in my eyes is to make a new release from 1.6.1 to 1.6.2. Perhaps this will carry over the change you've already made and update it on Bower.

@josephdburdick
Copy link
Contributor Author

Can confirm, after I forked this and created my own release I was able to access the proper bower.json information you already have in place. Please make a new release on Github so people pulling via Bower can get the updated info which improves its modularity for Browserify and the like!

adamwulf added a commit that referenced this pull request Feb 19, 2015
@adamwulf adamwulf merged commit 0416e34 into adamwulf:master Feb 19, 2015
@adamwulf
Copy link
Owner

Thanks!

@adamwulf
Copy link
Owner

just posted a new release as well pointing to this commit. I'm not a bower users, so lmk if this didn't do the trick for some reason

@josephdburdick
Copy link
Contributor Author

Awesome, I'll switch over to yours tomorrow when I return to my desk!
And for the record, this doesn't just bode well for bower users, I'm using Universal Modules to load your plugin as a shim. This is very helpful for writing JS modules and soon with ES6 is prevalent it will be standard. Thanks @adamwulf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants