-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make import symbol limit configurable #28
Comments
When the -vv argument is specified, warnings from pefile will be printed. This will help diagnose related to pefile such as #28.
I have fixed this issue and #29 and in the newly released version I added an option to display warnings from I fixed the issue of exceeding the number of imported symbols by using the I ran a quick test against a copy of |
Thank you very much for the exceedingly quick and helpful changes. Using |
Hello, thanks for this useful tool.
I came across a scenario where delvewheel-repair does not include all necessary DLLs. This was caused by pefile returning a truncated list of imports due to a limit on the number of imports parsed. I observe in CadQuery/cadquery#1048 (comment) that increasing
pefile.MAX_IMPORT_SYMBOLS
at least partially resolves some issues.My ideas for delvewheel are:
Allow
MAX_IMPORT_SYMBOLS
to be specified at the command-line, e.g.delvewheel repair --max_import_symbols=1000000
leads topefile.MAX_IMPORT_SYMBOLS = 1000000
before parsing;Display all pefile warnings to the user. Warning messages are accumulated on the PE object (example) and can be retrieved by
PE.get_warnings()
.The text was updated successfully, but these errors were encountered: