Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(framework) Add Docker GPU base image #4420

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Conversation

Robert-Steiner
Copy link
Member

@Robert-Steiner Robert-Steiner commented Nov 4, 2024

Issue

Description

This adds a GPU Docker base image. The image is nearly identical to the Flower Ubuntu image, except it uses the official NVIDIA CUDA base image. We need to check if we can the images with a non root user later.

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@Robert-Steiner Robert-Steiner self-assigned this Nov 4, 2024
@Robert-Steiner Robert-Steiner marked this pull request as ready for review November 5, 2024 18:09
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@Robert-Steiner Robert-Steiner merged commit 51ea8f8 into main Nov 6, 2024
53 checks passed
@Robert-Steiner Robert-Steiner deleted the feat/base-gpu-image branch November 6, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants