-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datasets) Add VerticalEvenPartitioner #4692
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-narozniak
requested review from
jafermarq,
tanertopal and
danieljanes
as code owners
December 12, 2024 16:47
adam-narozniak
changed the title
feat(datasets) Add EvenVerticalPartitioner
feat(datasets) Add VerticalEvenPartitioner
Dec 13, 2024
…lower into fds-add-vertical-even-partitioner
…lower into fds-add-vertical-even-partitioner
jafermarq
reviewed
Dec 19, 2024
datasets/flwr_datasets/partitioner/vertical_even_partitioner.py
Outdated
Show resolved
Hide resolved
datasets/flwr_datasets/partitioner/vertical_even_partitioner.py
Outdated
Show resolved
Hide resolved
datasets/flwr_datasets/partitioner/vertical_even_partitioner.py
Outdated
Show resolved
Hide resolved
datasets/flwr_datasets/partitioner/vertical_even_partitioner.py
Outdated
Show resolved
Hide resolved
jafermarq
reviewed
Dec 19, 2024
datasets/flwr_datasets/partitioner/vertical_even_partitioner.py
Outdated
Show resolved
Hide resolved
datasets/flwr_datasets/partitioner/vertical_even_partitioner_test.py
Outdated
Show resolved
Hide resolved
…lower into fds-add-vertical-even-partitioner
…est.py Co-authored-by: Javier <[email protected]>
jafermarq
previously approved these changes
Dec 19, 2024
jafermarq
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new class that produces even or approximately even number of partitions (in terms of number of columns).
This class can't be a subclass of
VerticalSizePartitioner
due to the inability of accurate fraction (neither count) specification of sizes. Why?e.g.
And here if using a new class
So why it is not possible to inherit?
an operation that creates either counts of fractions needs to happen at the init time (to pass the args to SizePartitinoer) However due to the late assignment of the dataset it's not possible to use count neither to provide a better way of assign fractions that [1/num_partitions] * num_partitions and the assign the remainder columns to the signed object.