Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Add set_node_public_key and get_node_public_key methods to LinkState #4765

Merged
merged 8 commits into from
Jan 9, 2025
Merged

feat(framework) Add set_node_public_key and get_node_public_key methods to LinkState #4765

merged 8 commits into from
Jan 9, 2025

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Jan 5, 2025

This PR aims to decouple node creation from public key assignment. Key changes include:

  • Removed the public_key argument from the create_node and delete_node methods.
  • Added and implemented the set_node_public_key and get_node_public_key methods.
  • Updated all unit tests and usages accordingly.

@panh99 panh99 marked this pull request as ready for review January 5, 2025 18:34
@danieljanes danieljanes enabled auto-merge (squash) January 9, 2025 22:13
@danieljanes danieljanes merged commit c41de46 into main Jan 9, 2025
55 checks passed
@danieljanes danieljanes deleted the amend-linkstate-keys branch January 9, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielnugraha danielnugraha danielnugraha left review comments

@jafermarq jafermarq jafermarq left review comments

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panh99 @danieljanes @jafermarq @danielnugraha