Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(framework) Move necessary utils from flwr.cli.config_utils to flwr.common.config #4838

Merged
merged 8 commits into from
Jan 22, 2025
Merged

refactor(framework) Move necessary utils from flwr.cli.config_utils to flwr.common.config #4838

merged 8 commits into from
Jan 22, 2025
+319 −323

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Jan 19, 2025 •
edited
Loading

@panh99 panh99 marked this pull request as draft January 19, 2025 22:20
jafermarq
jafermarq previously approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@jafermarq jafermarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quality refactoring

chongshenng
chongshenng reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@chongshenng chongshenng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Only one comment.

@panh99 panh99 mentioned this pull request Jan 21, 2025
Merged
@panh99 panh99 marked this pull request as ready for review January 21, 2025 12:56
@danieljanes danieljanes enabled auto-merge (squash) January 22, 2025 11:45
@danieljanes danieljanes merged commit 8cbc216 into main Jan 22, 2025
55 checks passed
@danieljanes danieljanes deleted the mv-config-utils branch January 22, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chongshenng chongshenng chongshenng left review comments

@danieljanes danieljanes danieljanes approved these changes

@jafermarq jafermarq jafermarq left review comments

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panh99 @danieljanes @jafermarq @chongshenng