Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto levels calculating incorrect value #126

Closed
StuartNicholls opened this issue Sep 23, 2022 · 0 comments
Closed

Auto levels calculating incorrect value #126

StuartNicholls opened this issue Sep 23, 2022 · 0 comments
Assignees
@StuartNicholls
Labels
accessibility bug

Comments

@StuartNicholls
Copy link
Contributor

Increments from _ariaLevel if it exists. AriaLevel is 0 (zero) by default, which will then report the heading level incorrectly/

Affects corses from exported from the authoring tool.

Suggest updating check for 0
StuartNicholls added a commit that referenced this issue Sep 23, 2022
@StuartNicholls
Fix: Auto aria-levels (Issue #126)
4309058 
Fixes issue #126. 

Only likely to occur when courses are exported from the Adapt Authoring tool. 

Occurs when _ariaLevel exists and is the default value. Affects subheadings in component (when override exists and set to 0(zero)
@StuartNicholls StuartNicholls mentioned this issue Sep 23, 2022
Merged
@oliverfoster oliverfoster moved this from New to Needs Reviewing in adapt_framework: The TODO Board Sep 26, 2022
oliverfoster pushed a commit that referenced this issue Sep 29, 2022
@StuartNicholls
Fix: Auto aria-levels (Issue #126) (#127)
f9e631a
github-actions bot pushed a commit that referenced this issue Sep 29, 2022
@semantic-release-bot
Chore(release): 7.2.3 [skip ci]
3a43432 
## [7.2.3](v7.2.2...v7.2.3) (2022-09-29)

### Fix

* Auto aria-levels (Issue #126) (#127) ([f9e631a](f9e631a)), closes [#126](#126) [#127](#127)
Repository owner moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StuartNicholls StuartNicholls

Labels
accessibility bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StuartNicholls @oliverfoster