Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate image alignment custom classes into property #128

Closed
guywillis opened this issue Nov 4, 2022 · 1 comment · Fixed by #129
Closed

Consolidate image alignment custom classes into property #128

guywillis opened this issue Nov 4, 2022 · 1 comment · Fixed by #129
Assignees
@guywillis
Labels
enhancement released

Comments

@guywillis
Copy link
Contributor

guywillis commented Nov 4, 2022 •
edited
Loading

Subject of the enhancement

At present, a user is required to type out the custom class required for changing the image alignment within an accordion item. This custom class has to be applied to the _classes field on the item or corresponding field within the authoring tool.

The application of the image alignment class could be optimised by converting the options to a drop down selection, similar to the vanilla's background image styles property.

Your environment

  • AAT / FW

Global issue adaptlearning/adapt_framework#3339
@guywillis guywillis self-assigned this Nov 4, 2022
@guywillis guywillis moved this from New to Assigned in adapt_framework: The TODO Board Nov 4, 2022
@guywillis guywillis mentioned this issue Nov 4, 2022
Merged
@guywillis guywillis moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Nov 4, 2022
oliverfoster pushed a commit that referenced this issue Nov 7, 2022
@guywillis
Update: image alignment property (fixes: #128) (#129)
3f78deb
Repository owner moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Nov 7, 2022
github-actions bot pushed a commit that referenced this issue Nov 7, 2022
@semantic-release-bot
Chore(release): 7.3.0 [skip ci]
caef722 
# [7.3.0](v7.2.3...v7.3.0) (2022-11-07)

### Update

* image alignment property (fixes: #128) (#129) ([3f78deb](3f78deb)), closes [#128](#128) [#129](#129)
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

🎉 This issue has been resolved in version 7.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guywillis guywillis

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update: image alignment property (fixes: #128) adaptlearning/adapt-contrib-accordion
1 participant
@guywillis