Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/115 Changed divs to spans inside button #116

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Conversation

oliverfoster
Copy link
Member

fixes #115

Fixed

  • Changed divs to spans inside buttons as divs are not allowed inside button elements

@oliverfoster oliverfoster self-assigned this May 30, 2022
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on:

MacBook Pro Monterey v12.4 - Chrome
iPhone SE v15.4 - Safari
Samsung Galaxy Tab A7 v11 - Chrome

Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with fw5.19.4, working as expected.

@joe-allen-89 joe-allen-89 merged commit f062a4d into master Jun 15, 2022
@joe-allen-89 joe-allen-89 deleted the issue/115 branch June 15, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

w3c validation Error Element div not allowed as child of element button in this context.
4 participants