Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BrowserFocus auto next errors when intentionally moving focus from hidden element #486

Closed
oliverfoster opened this issue Jan 24, 2024 · 1 comment · Fixed by #487
Closed

BrowserFocus auto next errors when intentionally moving focus from hidden element #486

oliverfoster opened this issue Jan 24, 2024 · 1 comment · Fixed by #487
Assignees
@oliverfoster
Labels
bug released

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Jan 24, 2024 •
edited
Loading

Subject of the issue

If focusNext or similar is called and moves focus from an element which is intentionally offscreen, then this if statement will cause adapt to autonext unintentionally here.

Autonext on blur should only occur when the event related target (the element receiving focus), is the body tag and is receiving focus because the target element has been disabled or otherwise hidden.
@oliverfoster oliverfoster self-assigned this Jan 24, 2024
oliverfoster added a commit that referenced this issue Jan 24, 2024
@oliverfoster
Fix: Auto focus next only when returning to body from disabled or hid…
6dbe198 
…den (fixes #486)
@oliverfoster oliverfoster mentioned this issue Jan 24, 2024
Merged
@oliverfoster oliverfoster moved this from New to Needs Reviewing in adapt_framework: The TODO Board Jan 24, 2024
oliverfoster added a commit that referenced this issue Feb 2, 2024
@oliverfoster
Fix: Auto focus next only when returning to body from disabled or hid…
ab127f1 
…den (fixes #486) (#487)
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Feb 2, 2024
github-actions bot pushed a commit that referenced this issue Feb 2, 2024
@semantic-release-bot
Chore(release): 6.45.1
8ccfa5c 
## [6.45.1](v6.45.0...v6.45.1) (2024-02-02)

### Fix

* Auto focus next only when returning to body from disabled or hidden (fixes #486) (#487) ([ab127f1](ab127f1)), closes [#486](#486) [#487](#487)
@oliverfoster
Copy link
Member Author

🎉 This issue has been resolved in version 6.45.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
None yet
Milestone
No milestone
1 participant
@oliverfoster