Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Added preRemove and remove events to contentObjectView #527

Merged
merged 1 commit into from
May 15, 2024
Merged

Fix: Added preRemove and remove events to contentObjectView #527

merged 1 commit into from
May 15, 2024

Conversation

oliverfoster
Copy link
Member

fixes #516

Fix

  • Added preRemove and remove events to contentObjectView

@oliverfoster oliverfoster self-assigned this Apr 30, 2024
@oliverfoster oliverfoster mentioned this pull request Apr 30, 2024
Merged
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

guywillis
guywillis approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 474faf3 into master May 15, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/516 branch May 15, 2024 09:26
github-actions bot pushed a commit that referenced this pull request May 15, 2024
@semantic-release-bot
Chore(release): 6.46.8
8bccfed 
## [6.46.8](v6.46.7...v6.46.8) (2024-05-15)

### Fix

* Added preRemove and remove events to contentObjectView (#527) ([474faf3](474faf3)), closes [#527](#527)
@oliverfoster
Copy link
Member Author

🎉 This PR is included in version 6.46.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StuartNicholls StuartNicholls StuartNicholls approved these changes

@guywillis guywillis guywillis approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HeadingView not destroyed when parent View is destroyed
4 participants
@oliverfoster @StuartNicholls @guywillis @cahirodoherty-learningpool