-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Allow any component to use mobileBody for smaller devices (fixes #538) #539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as expected thanks @swashbuck.
Should we do the same for component.hbs body
? I think Core wise, Media is the only component still using hbs templates.
Does this need raising as a separate issue so it's not forgotten when the PR is merged? |
@kirsty-hames Great idea. I've created issues for these two plugins. adaptlearning/adapt-contrib-hotgraphic#308 |
@kirsty-hames I've added So, for this to work in Media and other plugins that still use the older template, updates to the Media plugin's JS would be needed. The change in 2b565d8 will help to facilitate this, though. |
🎉 This PR is included in version 6.48.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Fix #538
New
mobileBody
property for component headersTesting
body
andmobileBody
value to any component.mobileBody
instead ofbody
.body
instead ofmobileBody
.Future consideration
Add
mobileBody
andmobileInstruction
to the core component schemas. Then, remove them from the schemas of components like Hot Graphic and Narrative. Would require migration scripts.