Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Drawer close animation. Drawer and notify open focus #621

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Fix: Drawer close animation. Drawer and notify open focus #621

merged 2 commits into from
Feb 6, 2025

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Feb 3, 2025 •
edited
Loading

Additional fixes to pr #601

fixes #619
fixes #620

Fix

@oliverfoster oliverfoster self-assigned this Feb 3, 2025
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

kirsty-hames
kirsty-hames approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected thanks 👍 Tested FF, Chrome, Safari and iPhone. Screen reader tested with voiceOver on Mac Safari.

I don't have access to JAWS to test issue #620 but can confirm #619 fixed.

guywillis
guywillis approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster oliverfoster merged commit 00cc695 into master Feb 6, 2025
@oliverfoster oliverfoster deleted the issue/620 branch February 6, 2025 15:44
github-actions bot pushed a commit that referenced this pull request Feb 6, 2025
@semantic-release-bot
Chore(release): 6.60.5
3cec6f1 
## [6.60.5](v6.60.4...v6.60.5) (2025-02-06)

### Fix

* Drawer close animation. Drawer and notify open focus (#621) ([00cc695](00cc695)), closes [#621](#621)
@oliverfoster
Copy link
Member Author

🎉 This PR is included in version 6.60.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@guywillis guywillis guywillis approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
adapt_framework: The TODO Board
Status: Recently Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drawer / Notify - Links in <dialog> Drawer closes prematurely when activating controls inside it by keyboard
4 participants
@oliverfoster @kirsty-hames @guywillis @cahirodoherty-learningpool