-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue/2799 Remove redundant behaviour and improve intellisense #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 23, 2022
This was referenced Mar 24, 2022
oliverfoster
commented
Mar 30, 2022
oliverfoster
commented
Mar 30, 2022
cahirodoherty-learningpool
approved these changes
Mar 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
lc-alexanderbenesch
approved these changes
Mar 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
eleanor-heath
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes adaptlearning/adapt_framework#2957
fixes adaptlearning/adapt_framework#2799
helps with adaptlearning/adapt_framework#3009
This should improve vscode intellisense substantially whilst helping us better define and utilise current Adapt APIs.
Moved
Adapt.register
,Adapt.getModelName
,Adapt.getModelClass
,Adapt.getViewName
andAdapt.getViewClass
functions andAdapt.store
property in tocore/js/components
Adapt.location
property tocore/js/location
with jsdocs for the available propertiesAdapt.wait
behaviour intocore/js/deprecated
Removed
scriptLoader
Deprecated
These now have console warnings about being deprecated
Adapt.a11y
forcore/js/a11y
Adapt.componentStore
forcore/js/components
Adapt.data
forcore/js/data
Adapt.device
forcore/js/device
Adapt.drawer
forcore/js/drawer
Adapt.location
forcore/js/location
Adapt.notify
forcore/js/notify
Adapt.offlineStorage
forcore/js/offlineStorage
Adapt.router
forcore/js/router
Adapt.startController
forcore/js/startController
Adapt.scrolling
forcore/js/scrolling
Adapt.store
forcore/js/components
Adapt.tracking
forcore/js/tracking
Adapt.navigateToElement
forcore/js/router
equivalentAdapt.register
forcore/js/components
equivalentAdapt.getViewName
forcore/js/components
equivalentAdapt.getViewClass
forcore/js/components
equivalentAdapt.getModelName
forcore/js/components
equivalentAdapt.getModelClass
forcore/js/components
equivalentAdapt.findById
forcore/js/data
equivalentAdapt.findViewByModelId
forcore/js/data
equivalentAdapt.findByTrackingPosition
forcore/js/data
equivalentChanged
html()
fordangerouslySetInnerHtml
Fixed
a11y
files and foldersrouter
,AdaptModel
,ContentObjectModel
andCourseModel
router
andstartController