add missing img alt text #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves adaptlearning/adapt_framework#3200 - remove aria-label from <img> as parent aria-hidden prevents label from being read - apply graphic alt text to input aria-label instead
Co-authored-by: tomgreenfield <[email protected]>
Co-authored-by: tomgreenfield <[email protected]>
js/adapt-contrib-gmcq.js
Outdated
Comment on lines
70
to
72
| $.a11y_normalize(itemModel.get('text')), | ||
| '. ', | ||
| $.a11y_normalize(itemModel.get('_graphic').alt) |
There was a problem hiding this comment.
There is a new API for this:
Suggested change
| $.a11y_normalize(itemModel.get('text')), | |
| '. ', | |
| $.a11y_normalize(itemModel.get('_graphic').alt) | |
| Adapt.a11y.normalize(itemModel.get('text')), | |
| '. ', | |
| Adapt.a11y.normalize(itemModel.get('_graphic').alt) |
See also lines 91 & 93.
@oliverfoster, probably best to leave the switch to the direct a11y.normalize() for the React PR.
There was a problem hiding this comment.
Nah, do it now. Here's the issue adaptlearning/adapt_framework#3009
There was a problem hiding this comment.
See also lines 91 & 93.
Future note: this bit wasn't done.
|
@kirsty-hames could you have a look at this this week if you have time please? |
Co-authored-by: tomgreenfield <[email protected]>
Co-authored-by: tomgreenfield <[email protected]>
oliverfoster
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves adaptlearning/adapt_framework#3200
<img>as parentaria-hiddenprevents label from being read<input>aria-labelinstead