Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Migration scripts added to repo (fixes #125) #126

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

New: Migration scripts added to repo (fixes #125) #126

wants to merge 10 commits into from

Conversation

joe-allen-89
Copy link
Contributor

#125

New

@joe-allen-89 joe-allen-89 self-assigned this Feb 12, 2025
@joe-allen-89 joe-allen-89 linked an issue Feb 12, 2025 that may be closed by this pull request
Add migration scripts to repo #125
Open
@joe-allen-89 joe-allen-89 requested a review from swashbuck March 3, 2025 17:21
@swashbuck
Copy link
Contributor

@joe-allen-89 Looks like we are missing the custom types that were added in 5.4.1. Then, 5.5.3 actually makes them selectable options for each resource item.

swashbuck
swashbuck reviewed Mar 3, 2025
View reviewed changes
swashbuck
swashbuck reviewed Mar 3, 2025
View reviewed changes
swashbuck
swashbuck reviewed Mar 3, 2025
View reviewed changes
swashbuck
swashbuck reviewed Mar 3, 2025
View reviewed changes
swashbuck
swashbuck reviewed Mar 3, 2025
View reviewed changes
swashbuck
swashbuck reviewed Mar 3, 2025
View reviewed changes
swashbuck
swashbuck reviewed Mar 3, 2025
View reviewed changes
@joe-allen-89
Copy link
Contributor Author

@joe-allen-89 Looks like we are missing the custom types that were added in 5.4.1. Then, 5.5.3 actually makes them selectable options for each resource item.

@swashbuck Added the customTypes but we don't need to do anything with adding them as enums in the 5.5.3 schema change. All other comments addressed, thanks for the review.

@joe-allen-89 joe-allen-89 requested a review from swashbuck March 4, 2025 11:07
swashbuck
swashbuck approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swashbuck swashbuck swashbuck approved these changes

@chris-steele chris-steele Awaiting requested review from chris-steele

Assignees

@joe-allen-89 joe-allen-89

Labels
enhancement ready to release
Projects
adapt_framework: The TODO Board
Status: Needs Reviewing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add migration scripts to repo
2 participants
@joe-allen-89 @swashbuck