Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Allow slide step prefix and suffix (fixes #173) #182

Merged
merged 7 commits into from
Apr 17, 2023
Merged

Fix: Allow slide step prefix and suffix (fixes #173) #182

merged 7 commits into from
Apr 17, 2023

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Mar 20, 2023 •
edited
Loading

Fixes #173

Fix

  • Adds new Slider properties for scaleStepPrefix and scaleStepSuffix.

Testing

  1. Create a new Slider instance
  2. Add the following properties:
"scaleStepPrefix": "$",
"scaleStepSuffix": "K",

dollars

@swashbuck swashbuck self-assigned this Mar 20, 2023
@swashbuck swashbuck changed the title Fix: Add documentation (fixes #173) Fix: Allow slide step prefix and suffix (fixes #173) Mar 20, 2023
@swashbuck
Copy link
Contributor Author

Will wait on #179 and #180 before updating the schemas.

kirsty-hames
kirsty-hames reviewed Mar 23, 2023
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well thanks @swashbuck.

Regarding accessibility, the slider__label-start, slider__label-end and slider__item-inputall use _scaleStart, _scaleEnd and the current value for aria-labels. Is this sufficient enough or should the prefix/suffix be included in these too?

@swashbuck
Copy link
Contributor Author

Regarding accessibility, the slider__label-start, slider__label-end and slider__item-inputall use _scaleStart, _scaleEnd and the current value for aria-labels. Is this sufficient enough or should the prefix/suffix be included in these too?

@kirsty-hames Good callout. I've added the suffix and prefix to the start and end labels. For slider__item-input, though, I believe all of the aria values have to be a decimal number? That includes aria-valuenow, aria-valuemin, and aria-valuemax.

@swashbuck swashbuck marked this pull request as ready for review March 23, 2023 16:29
@swashbuck
Copy link
Contributor Author

Schemas have been updated.

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Mar 28, 2023
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@swashbuck swashbuck requested a review from kirsty-hames March 28, 2023 16:22
@swashbuck swashbuck requested a review from guywillis April 10, 2023 17:04
@swashbuck swashbuck merged commit 3bf8723 into master Apr 17, 2023
@swashbuck swashbuck deleted the issue/173 branch April 17, 2023 14:19
@github-actions
Copy link

🎉 This PR is included in version 4.3.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@oliverfoster
Copy link
Member

image

@oliverfoster oliverfoster mentioned this pull request Apr 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@guywillis guywillis Awaiting requested review from guywillis

Assignees

@swashbuck swashbuck

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow slide step prefix and suffix
4 participants
@swashbuck @oliverfoster @kirsty-hames @cahirodoherty-learningpool