Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Added support for _canShowCorrectness #213

Merged
merged 8 commits into from
Oct 28, 2024
Merged

New: Added support for _canShowCorrectness #213

merged 8 commits into from
Oct 28, 2024

Conversation

kirsty-hames
Copy link
Contributor

@kirsty-hames kirsty-hames commented Sep 25, 2024 •
edited
Loading

part of adaptlearning/adapt_framework#3597

Allows option _canShowCorrectness instead of _canShowModelAnswer, to replace the associated toggle button and display correctness directly on the component.

New

  • Added support for _canShowCorrectness
  • .show-correctness widget class appended for consistency with other question components. Note, there's no associated styling currently.
  • Correctness ARIA applied to slider numbers. For consistency with other question items, selectable items are marked up with an aria-label consisting of correctness, selection and value.

slider_standard

Requires

ref adaptlearning/adapt-contrib-core#582

@kirsty-hames kirsty-hames self-assigned this Sep 25, 2024
@kirsty-hames
example and readme updated
d29919c
@kirsty-hames
schemas updated
a61b4b8
@kirsty-hames
preserve spacing for correctness icons when _canShowCorrectness
bef8f94 
- prevents the component height expanding when icons are displayed
- consistent with Matching and Textinput answer container spacing
@kirsty-hames
set correctness and selection aria on slider numbers
767ab0b 
- for consistency with other question items, selectable items are marked up with an aria-label consisting of correctness, selection and value.
- set aria-hidden on correctness icons as correctness is covered by number aria-label instead.
- apply aria-disabled to clickable slider numbers once submitted. Note, Voiceover on Mac reads numbers as 'clickable'.
joe-allen-89
joe-allen-89 reviewed Oct 23, 2024
View reviewed changes
joe-allen-89
joe-allen-89 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster oliverfoster merged commit a73560a into master Oct 28, 2024
github-actions bot pushed a commit that referenced this pull request Oct 28, 2024
@semantic-release-bot
Chore(release): 4.6.0 [skip ci]
8ed096a 
# [4.6.0](v4.5.6...v4.6.0) (2024-10-28)

### New

* Added support for _canShowCorrectness (#213) ([a73560a](a73560a)), closes [#213](#213)
@oliverfoster oliverfoster deleted the issue/3597 branch October 28, 2024 10:23
github-actions bot pushed a commit to nagyist/adapt-contrib-slider that referenced this pull request Mar 3, 2025
@semantic-release-bot
Chore(release): 2.2.0 [skip ci]
2487f5c 
# [2.2.0](v2.1.6...v2.2.0) (2025-03-03)

### accessibility

* issue/#2165 updated component description (adaptlearning#134) ([392f9db](392f9db)), closes [issue/#2165](https://github.com/nagyist/adapt-contrib-slider/issues/2165) [adaptlearning#134](https://github.com/nagyist/adapt-contrib-slider/issues/134) [issue/#2165](https://github.com/nagyist/adapt-contrib-slider/issues/2165)

### chore

* added package.json (adaptlearning#149) ([45b1f37](45b1f37)), closes [adaptlearning#149](https://github.com/nagyist/adapt-contrib-slider/issues/149) [#3072](https://github.com/nagyist/adapt-contrib-slider/issues/3072)

### Chore

* Add support for new issue experience (fixes adaptlearning#216) (adaptlearning#219) ([662cbd1](662cbd1)), closes [adaptlearning#216](https://github.com/nagyist/adapt-contrib-slider/issues/216) [adaptlearning#219](https://github.com/nagyist/adapt-contrib-slider/issues/219)
* e2e tests on slider component (Issue/201) (adaptlearning#202) ([4e21470](4e21470)), closes [adaptlearning#202](https://github.com/nagyist/adapt-contrib-slider/issues/202)

### Fix

* _globals schema nesting (adaptlearning#179) ([960acc5](960acc5)), closes [adaptlearning#179](https://github.com/nagyist/adapt-contrib-slider/issues/179)
* Add ariaQuestion to slider (fixes: 170) (adaptlearning#171) ([e1c0d42](e1c0d42)), closes [adaptlearning#171](https://github.com/nagyist/adapt-contrib-slider/issues/171)
* Add scale context to slider start and end labels (adaptlearning#176) ([68f06bf](68f06bf)), closes [adaptlearning#176](https://github.com/nagyist/adapt-contrib-slider/issues/176)
* Added gitignore for release automation (adaptlearning#162) ([cb1c282](cb1c282)), closes [adaptlearning#162](https://github.com/nagyist/adapt-contrib-slider/issues/162)
* Added release automation (adaptlearning#160) ([10a000f](10a000f)), closes [adaptlearning#160](https://github.com/nagyist/adapt-contrib-slider/issues/160)
* Allow floats in slider position to item selection (fixes adaptlearning#193) (adaptlearning#194) ([a336e60](a336e60)), closes [adaptlearning#193](https://github.com/nagyist/adapt-contrib-slider/issues/193) [adaptlearning#194](https://github.com/nagyist/adapt-contrib-slider/issues/194)
* Allow slide step prefix and suffix (fixes adaptlearning#173) ([3bf8723](3bf8723)), closes [adaptlearning#173](https://github.com/nagyist/adapt-contrib-slider/issues/173)
* aria-valuetext attribute added to the slider to read out scaleStepPrefix/scaleStepSuffix (fixes adaptlearning#211) (adaptlearning#212) ([f4f88cc](f4f88cc)), closes [adaptlearning#211](https://github.com/nagyist/adapt-contrib-slider/issues/211) [adaptlearning#212](https://github.com/nagyist/adapt-contrib-slider/issues/212) [adaptlearning#211](https://github.com/nagyist/adapt-contrib-slider/issues/211)
* ariaScaleName property added (adaptlearning#192) ([c8737a1](c8737a1)), closes [adaptlearning#192](https://github.com/nagyist/adapt-contrib-slider/issues/192)
* Bump braces from 3.0.2 to 3.0.3 (adaptlearning#208) ([70808b8](70808b8)), closes [adaptlearning#208](https://github.com/nagyist/adapt-contrib-slider/issues/208)
* Bump http-cache-semantics from 4.1.0 to 4.1.1 (adaptlearning#174) ([bee20a7](bee20a7)), closes [adaptlearning#174](https://github.com/nagyist/adapt-contrib-slider/issues/174)
* Convert focus to focus-visible (fixes adaptlearning#166) ([872d607](872d607)), closes [adaptlearning#166](https://github.com/nagyist/adapt-contrib-slider/issues/166)
* Convert hbs to jsx template (fixes adaptlearning#163) (adaptlearning#164) ([897b3e4](897b3e4)), closes [adaptlearning#163](https://github.com/nagyist/adapt-contrib-slider/issues/163) [adaptlearning#164](https://github.com/nagyist/adapt-contrib-slider/issues/164)
* Feedback title/altTitle documentation and schema updates (adaptlearning#180) ([5ec2413](5ec2413)), closes [adaptlearning#180](https://github.com/nagyist/adapt-contrib-slider/issues/180)
* Fill styling for sliders (adaptlearning#183) ([1e63ba0](1e63ba0)), closes [adaptlearning#183](https://github.com/nagyist/adapt-contrib-slider/issues/183)
* included scale step in input slider jsx (fix adaptlearning#187) (adaptlearning#190) ([4c9df59](4c9df59)), closes [adaptlearning#187](https://github.com/nagyist/adapt-contrib-slider/issues/187) [adaptlearning#190](https://github.com/nagyist/adapt-contrib-slider/issues/190)
* missing attribute values causing runtime error (adaptlearning#205) ([a85cdaf](a85cdaf)), closes [adaptlearning#205](https://github.com/nagyist/adapt-contrib-slider/issues/205) [adaptlearning#204](https://github.com/nagyist/adapt-contrib-slider/issues/204)
* moved striphtml function outside loop (fixes adaptlearning#207) ([79d5d69](79d5d69)), closes [adaptlearning#207](https://github.com/nagyist/adapt-contrib-slider/issues/207)
* Remove rangeslider library styles (fixes adaptlearning#175) ([83fafa3](83fafa3)), closes [adaptlearning#175](https://github.com/nagyist/adapt-contrib-slider/issues/175)
* role added to component__widget div (fixes adaptlearning#209) (adaptlearning#210) ([b66020c](b66020c)), closes [adaptlearning#209](https://github.com/nagyist/adapt-contrib-slider/issues/209) [adaptlearning#210](https://github.com/nagyist/adapt-contrib-slider/issues/210)
* String defaults for scaleStepPrefix and scaleStepSuffix (adaptlearning#186) ([3de631c](3de631c)), closes [adaptlearning#186](https://github.com/nagyist/adapt-contrib-slider/issues/186)
* Version numbers removed from Readme files ([2c7cb8f](2c7cb8f))
* Vertically center number in selection circle (fixes adaptlearning#200) ([4b35712](4b35712)), closes [adaptlearning#200](https://github.com/nagyist/adapt-contrib-slider/issues/200)

### New

* Added support for _canShowCorrectness (adaptlearning#213) ([a73560a](a73560a)), closes [adaptlearning#213](https://github.com/nagyist/adapt-contrib-slider/issues/213)
* Issue and pr project addition automation (refs adaptlearning/adapt_framework#3315) (adaptlearning#159) ([984a912](984a912)), closes [adaptlearning#159](https://github.com/nagyist/adapt-contrib-slider/issues/159)
* Provide default instruction text (fixes adaptlearning#167) (adaptlearning#168) ([181afa8](181afa8)), closes [adaptlearning#167](https://github.com/nagyist/adapt-contrib-slider/issues/167) [adaptlearning#168](https://github.com/nagyist/adapt-contrib-slider/issues/168)
* use native slider instead of rangeslider (fixes adaptlearning#161) ([2c524f5](2c524f5)), closes [adaptlearning#161](https://github.com/nagyist/adapt-contrib-slider/issues/161)

### Update

* remove ariaQuestion placeholder text (fixes adaptlearning#196) adaptlearning#197 ([832bd98](832bd98)), closes [adaptlearning#196](https://github.com/nagyist/adapt-contrib-slider/issues/196) [adaptlearning#197](https://github.com/nagyist/adapt-contrib-slider/issues/197)
* remove implied aria properties from <input type="range"> (adaptlearning#195) ([f79e5bf](f79e5bf)), closes [adaptlearning#195](https://github.com/nagyist/adapt-contrib-slider/issues/195)

### Upgrade

* Bump ip from 1.1.8 to 1.1.9 (adaptlearning#199) ([d585fc2](d585fc2)), closes [adaptlearning#199](https://github.com/nagyist/adapt-contrib-slider/issues/199)
* Bump yaml and semantic-release (adaptlearning#188) ([aa11148](aa11148)), closes [adaptlearning#188](https://github.com/nagyist/adapt-contrib-slider/issues/188)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@ethan-lp ethan-lp ethan-lp approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@kirsty-hames kirsty-hames

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kirsty-hames @oliverfoster @ethan-lp @joe-allen-89