Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2808 - convert to es6 classes, added imports/exports and return early #303

Merged
merged 2 commits into from
Oct 28, 2021
Merged

2808 - convert to es6 classes, added imports/exports and return early #303

merged 2 commits into from
Oct 28, 2021

Conversation

eleanor-heath
Copy link
Contributor

@eleanor-heath eleanor-heath self-assigned this Sep 23, 2021
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

ethan-lp
ethan-lp approved these changes Sep 23, 2021
View reviewed changes
Copy link

@ethan-lp ethan-lp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

lc-alexanderbenesch
lc-alexanderbenesch approved these changes Oct 28, 2021
View reviewed changes
Copy link

@lc-alexanderbenesch lc-alexanderbenesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀👍

@oliverfoster oliverfoster merged commit 025837b into master Oct 28, 2021
@oliverfoster oliverfoster deleted the 2808-convert-to-es6 branch October 28, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@ethan-lp ethan-lp ethan-lp approved these changes

@lc-alexanderbenesch lc-alexanderbenesch lc-alexanderbenesch approved these changes

@danielghost danielghost Awaiting requested review from danielghost

@oliverfoster oliverfoster Awaiting requested review from oliverfoster

@guywillis guywillis Awaiting requested review from guywillis

@joe-allen-89 joe-allen-89 Awaiting requested review from joe-allen-89

@chris-steele chris-steele Awaiting requested review from chris-steele

Assignees

@eleanor-heath eleanor-heath

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eleanor-heath @cahirodoherty-learningpool @ethan-lp @lc-alexanderbenesch @oliverfoster