issue/2939 remove placeholder alt text + update schema alt text description (take 2) #2981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moloko
approved these changes
Dec 7, 2020
|
👍 |
oliverfoster
approved these changes
Dec 7, 2020
|
@kirsty-hames, could you start again with a fresh branch based off master please? I believe the presence of the revert commit means the majority of your intended changes were not pulling through. I've tried merging master into this one but it hasn't helped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...when adding a schema alt text 'title', the previous commit was reverted by accident https://github.com/adaptlearning/adapt_framework/pull/2953/files