Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bugs introduced by Interaction Mask component #1209

Closed
wants to merge 5 commits into from

Conversation

amanmahajan7
Copy link
Contributor

@amanmahajan7 amanmahajan7 commented May 26, 2018

  • Fix Cell component export
  • Fix columns count for Immutable list
  • Fix cell styles
  • Unselect selected cell when clicked outside the grid
  • Fix drag exception in Internet explorer

Internet Explorer only supports 'text' and 'URL' for the 'type' argument. If you try setting type to anything else, IE will throw an exception.

  • Fix performance regression in firefox. When the grid is scrolled to the middle then the drag fill operation is extremely slow. This is caused by this bug.

The problem comes from the fact that the item's container is shifted right with a CSS transformation (translateX). The ghost is positioned like there was no translation.

@amanmahajan7 amanmahajan7 changed the title Fix drag fill in Internet Explorer and Firefox Fix some bugs introduced by Interaction Mask component May 30, 2018
@amanmahajan7
Copy link
Contributor Author

amanmahajan7 commented Jun 17, 2018

Replaced by
#1227
#1228
#1229

@amanmahajan7 amanmahajan7 deleted the am-fix-ff-drag-performance branch March 14, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant