Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the no-class-assign #1398

Merged
merged 2 commits into from
Nov 26, 2018
Merged

Enable the no-class-assign #1398

merged 2 commits into from
Nov 26, 2018

Conversation

amanmahajan7
Copy link
Contributor

  • Enable the no-class-assign rule
  • Fix row export. This fixes the row re-order example

amanmahajan7
amanmahajan7 commented Nov 26, 2018
View reviewed changes
packages/react-data-grid/src/index.js
@@ -1,12 +1,15 @@
import Grid from './ReactDataGrid';
import RowComparer from 'common/utils/RowComparer';
import Cell from './Cell';
import Row from './Row';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Row uses export default and require syntax returns an object instead of the default import

@amanmahajan7 amanmahajan7 merged commit fd6bed9 into master Nov 26, 2018
@amanmahajan7 amanmahajan7 deleted the am-no-class-assign branch November 26, 2018 21:50
@amanmahajan7 amanmahajan7 mentioned this pull request Nov 27, 2018
Merged
rossjp pushed a commit to rossjp/react-data-grid that referenced this pull request Dec 14, 2018
@amanmahajan7 @rossjp
Enable the no-class-assign (adazzle#1398)
458b5f3 
* Enable the no-class-assign

* Fix Row export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nstepien nstepien nstepien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amanmahajan7 @nstepien