Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scroll-behavior: smooth; #2191

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Add scroll-behavior: smooth; #2191

merged 2 commits into from
Oct 27, 2020

Conversation

nstepien
Copy link
Contributor

It makes the "Scroll To Row" demo scroll the grid smoothly.
Since it's just CSS it's easy to disable.
WDYT?

@nstepien nstepien requested a review from amanmahajan7 October 27, 2020 18:26
@nstepien nstepien self-assigned this Oct 27, 2020
@amanmahajan7 amanmahajan7 merged commit acee66f into canary Oct 27, 2020
@amanmahajan7 amanmahajan7 deleted the smooth branch October 27, 2020 22:13
nstepien added a commit that referenced this pull request Nov 2, 2020
@nstepien
Revert "Add scroll-behavior: smooth; (#2191)"
d68af01 
This reverts commit acee66f.
amanmahajan7 pushed a commit that referenced this pull request Nov 2, 2020
@nstepien
Only make scrollToRow smooth (#2200)
d6866c9 
* Revert "Add `scroll-behavior: smooth;` (#2191)"

This reverts commit acee66f.

* Make scrollToRow smooth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanmahajan7 amanmahajan7 amanmahajan7 approved these changes

Assignees

@nstepien nstepien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nstepien @amanmahajan7