Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-added selected and active-drag-cell styles #591

Closed
wants to merge 1 commit into from
Closed

Re-added selected and active-drag-cell styles #591

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 3, 2017

These were previously removed, readding fixes cell selected and drag cell styles

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Styling around selected cell is missing

What is the new behavior?
Adds these styles back for selected cell and active-drag-cell

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

These were previously removed, readding fixes cell selected and drag cell styles
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b5a6c18 on chris-brannen-alps:master into ** on adazzle:master**.

@malonecj
Copy link
Contributor

malonecj commented Jan 5, 2017

These were removed for performance purposes. When navigating with keyboard, changing the styles of the selected cell was one of the factors that was contributing to lag. Instead we moved this to use the :focus pseudo class, which now has an outline.

https://github.com/adazzle/react-data-grid/blob/master/themes/react-data-grid.less#L88

Is there any reason this is not sufficient?

@ghost
Copy link
Author

ghost commented Jan 9, 2017

I've got two grids on the same page, which both need to show a selected cell and using :focus causes one to lose styling when the other is selected is there a way around this?

@malonecj
Copy link
Contributor

This will be re-enabled in v4 of the ReactDataGrid, when we move Cell selection responsibilities into a dedicated SelectionMask component. You can see progress here

@malonecj malonecj closed this Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants