Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: replace createClass to be compatible with React 16 #970

Merged
merged 1 commit into from
Oct 18, 2017

Conversation

philquinn
Copy link
Contributor

Description

createClass has been deprecated and no longer exists in React 16. We want to upgrade to 16 but are blocked by this. I ran the codemod to replace createClass. Some had to be manually done.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

Uses deprecated createClass

What is the new behavior?

No longer uses createClass. Same behavior.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 186c963 on philquinn:fix-create-class-for-react-16 into ** on adazzle:master**.

@philquinn
Copy link
Contributor Author

@malonecj can you give this a look please?

Copy link
Contributor

@malonecj malonecj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thanks @philquinn

@malonecj malonecj merged commit dc2ad1e into adazzle:master Oct 18, 2017
@philquinn philquinn deleted the fix-create-class-for-react-16 branch October 18, 2017 21:15
@philquinn
Copy link
Contributor Author

@malonecj No problem. Thanks for merging

@PaulInglis
Copy link

Do we have any time frame for when this will make it into a release?

@wKovacs64
Copy link

@PaulInglis It's been live since 2.0.61.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants