test stream ingestion PR for diffing #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adchia
force-pushed
the
sfv_other_online_stores
branch
from
4fa27fa to
acf65c9
Compare
richardcann
reviewed
Jan 19, 2022
Comment on lines
+206
to
+218
| if existing_entity and existing_entity["event_ts"] >= new_ts: | ||
| continue |
There was a problem hiding this comment.
Not entirely sure this would improve speed as we are still traversing through the same number of elements, but we could remove L190-197 and merge the two traversals like this:
Suggested change
| if existing_entity and existing_entity["event_ts"] >= new_ts: | |
| continue | |
| if existing_entity and existing_entity["event_ts"] >= new_ts: | |
| entities.append(existing_key) | |
| continue |
adchia
force-pushed
the
sfv_other_online_stores
branch
from
accd797 to
f82cbd2
Compare
adchia
force-pushed
the
sfv_other_online_stores
branch
from
f82cbd2 to
05f4e8f
Compare
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds timestamp checking for stream ingestion in datastore + SQL. Begins to modify universal tests to run over datastore and local stores too
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: