-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump next-transpile-modules from 5.0.0 to 6.0.0 #1444
build(deps): bump next-transpile-modules from 5.0.0 to 6.0.0 #1444
Conversation
57a233d
to
d4c3a19
Compare
Bumps [next-transpile-modules](https://github.com/martpie/next-transpile-modules) from 5.0.0 to 6.0.0. - [Release notes](https://github.com/martpie/next-transpile-modules/releases) - [Commits](martpie/next-transpile-modules@5.0.0...6.0.0) Signed-off-by: dependabot[bot] <[email protected]>
d4c3a19
to
0f527cc
Compare
@@ -13,11 +13,11 @@ module.exports = (withCustomBabelConfigFile( | |||
'@adeira/graphql-relay', | |||
'@adeira/js', | |||
'@adeira/monorepo-utils', | |||
'@adeira/murmur-hash', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michalsanger Why is the murmur hash needed here? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand this, during a build within a monorepo, @adeira
packages are not transpiled and we have to explicitly list them here. The murmur-hash
is used in sx
that's how it gets into build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ay caramba. So it's a dependency of a dependency. That's what I was afraid of. 🙈
I'd argue that this package (next-transpile-modules
) no longer serves the purpose we were using it for. You have to be explicit like this since version 5 but what we really want to do is to transpile the @adeira/*
scope and that's it (without enumerating every possible and even deeply nested workspace 🤦).
I will talk with the authors and see if we should fork it or what. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asked here: martpie/next-transpile-modules#143
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to get this programmatically using yarn workspaces info
and grabbing all dependencies and nested dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you find an alternate package / solution for this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are transpiling workspaces from this monorepo, we decided to fetch it programmatically using the yarn workspaces info
command, you can see the PR (here)[https://github.com//pull/1462]
Bumps next-transpile-modules from 5.0.0 to 6.0.0.
Release notes
Sourced from next-transpile-modules's releases.
Commits
59dc451
6.0.029fca16
Merge pull request #141 from martpie/resolve-modules-to-their-root-package-jsonca913a0
Update compatibility table61c1e7d
Naming consistency improvementscc78e39
Update notes7c586c8
Resolve modules to the directory of their package.json (instead of their dirn...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually