Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump next-transpile-modules from 5.0.0 to 6.0.0 #1444

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 2, 2020

Bumps next-transpile-modules from 5.0.0 to 6.0.0.

Release notes

Sourced from next-transpile-modules's releases.

6.0.0

Hello there 👋

shortly after the release of v5, here's v6, which solves some edgecases when transpiling modules. Again, no API changes, I still consider it major version as your build might break with this release.

The breaking changes are indicated by the ⚠️ icon.

Coming from v4? -> then you can just upgrade to v6 directly (while still reading the changes of v5), this fix should not concern you. ;)

⚠️ Fixed resolution strategy for packages resolving their main field to a sub-directory

Let's say a module/package is as follows:

styleguide/
    components/
    utils/ 
    package.json # <- `main` field resolving to components/index.js 

with v5, then only styleguide/components would get transpiled, and styleguide/utils/ would get ignored.

In v6, the behavior is similar to v4: everything in styleguide will get transpiled: components/ and utils/.

We lose granularity, but we get a much better DX out-of-the-box, and it matches the behavior of v4. This should solve most of the issues that you may have faced with v5.

Thanks to everyone who helped me test this 🙌

cheers!

Commits
  • 59dc451 6.0.0
  • 29fca16 Merge pull request #141 from martpie/resolve-modules-to-their-root-package-json
  • ca913a0 Update compatibility table
  • 61c1e7d Naming consistency improvements
  • cc78e39 Update notes
  • 7c586c8 Resolve modules to the directory of their package.json (instead of their dirn...
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

@dependabot dependabot bot added automerge dependencies Pull requests that update a dependency file labels Dec 2, 2020
@vercel vercel bot temporarily deployed to Preview – universe-example-relay December 2, 2020 16:14 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-sx-tailwind-website December 2, 2020 16:14 Inactive
@michalsanger michalsanger force-pushed the dependabot/npm_and_yarn/next-transpile-modules-6.0.0 branch from 57a233d to d4c3a19 Compare December 2, 2020 18:36
@vercel vercel bot temporarily deployed to Preview – universe-sx-tailwind-website December 2, 2020 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-example-relay December 2, 2020 18:36 Inactive
@michalsanger michalsanger force-pushed the dependabot/npm_and_yarn/next-transpile-modules-6.0.0 branch from d4c3a19 to 0f527cc Compare December 2, 2020 18:50
@vercel vercel bot temporarily deployed to Preview – universe-example-relay December 2, 2020 18:50 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-sx-tailwind-website December 2, 2020 18:50 Inactive
@@ -13,11 +13,11 @@ module.exports = (withCustomBabelConfigFile(
'@adeira/graphql-relay',
'@adeira/js',
'@adeira/monorepo-utils',
'@adeira/murmur-hash',
Copy link
Member

@mrtnzlml mrtnzlml Dec 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michalsanger Why is the murmur hash needed here? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand this, during a build within a monorepo, @adeira packages are not transpiled and we have to explicitly list them here. The murmur-hash is used in sx that's how it gets into build.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ay caramba. So it's a dependency of a dependency. That's what I was afraid of. 🙈

I'd argue that this package (next-transpile-modules) no longer serves the purpose we were using it for. You have to be explicit like this since version 5 but what we really want to do is to transpile the @adeira/* scope and that's it (without enumerating every possible and even deeply nested workspace 🤦).

I will talk with the authors and see if we should fork it or what. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to get this programmatically using yarn workspaces info and grabbing all dependencies and nested dependencies.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you find an alternate package / solution for this ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are transpiling workspaces from this monorepo, we decided to fetch it programmatically using the yarn workspaces info command, you can see the PR (here)[https://github.com//pull/1462]

@mrtnzlml mrtnzlml removed the automerge label Dec 3, 2020
@vercel vercel bot temporarily deployed to Preview – universe-example-relay December 3, 2020 13:52 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-sx-tailwind-website December 3, 2020 13:52 Inactive
@kodiakhq kodiakhq bot merged commit c02b5bc into master Dec 3, 2020
@kodiakhq kodiakhq bot deleted the dependabot/npm_and_yarn/next-transpile-modules-6.0.0 branch December 3, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants