Revert "Flow: use Indexed Access Types" #2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cf0a020 We are still getting the following error: ```text Syntax error: Unexpected token, expected "]" ``` Seems like some dependencies are still not updated. Not sure which ones. Will try some time later.
michalsanger
approved these changes
Jul 1, 2021
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
mrtnzlml
added a commit
that referenced
this pull request
Dec 16, 2021
This commit partially reverts #2662 Flow config option `indexed_access` was removed in https://github.com/facebook/flow/releases/tag/v0.164.0 (indexed access is enabled by default in Flow) so this commit only enabled the Eslint rule and fixes related issues in our codebase. See: https://flow.org/en/docs/types/indexed-access/
mrtnzlml
added a commit
that referenced
this pull request
Dec 16, 2021
This commit partially reverts #2662 Flow config option `indexed_access` was removed in https://github.com/facebook/flow/releases/tag/v0.164.0 (indexed access is enabled by default in Flow) so this commit only enabled the Eslint rule and fixes related issues in our codebase. See: https://flow.org/en/docs/types/indexed-access/
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 17, 2021
This commit partially reverts #2662 Flow config option `indexed_access` was removed in https://github.com/facebook/flow/releases/tag/v0.164.0 (indexed access is enabled by default in Flow) so this commit only enabled the Eslint rule and fixes related issues in our codebase. See: https://flow.org/en/docs/types/indexed-access/
adeira-github-bot
pushed a commit
to adeira/eslint-config-adeira
that referenced
this pull request
Dec 17, 2021
This commit partially reverts adeira/universe#2662 Flow config option `indexed_access` was removed in https://github.com/facebook/flow/releases/tag/v0.164.0 (indexed access is enabled by default in Flow) so this commit only enabled the Eslint rule and fixes related issues in our codebase. See: https://flow.org/en/docs/types/indexed-access/ adeira-source-id: 729591a0639f72a640b59b5833b351899ab71b0a
adeira-github-bot
pushed a commit
to adeira/relay
that referenced
this pull request
Dec 17, 2021
This commit partially reverts adeira/universe#2662 Flow config option `indexed_access` was removed in https://github.com/facebook/flow/releases/tag/v0.164.0 (indexed access is enabled by default in Flow) so this commit only enabled the Eslint rule and fixes related issues in our codebase. See: https://flow.org/en/docs/types/indexed-access/ adeira-source-id: 729591a0639f72a640b59b5833b351899ab71b0a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cf0a020
We are still getting the following error:
Seems like some dependencies are still not updated. Not sure which ones. Will try some time later.