Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate name and definition of union types to prevent Array naming issues #521

Merged
merged 7 commits into from
Sep 24, 2023

Conversation

leifniem
Copy link
Contributor

The current version produces the following code

export type number | stringArray = (number | string)[];

If i did not miss anything vital this should produce the correct type names.

@leifniem
Copy link
Contributor Author

leifniem commented May 10, 2023

I just noticed a place where this might not be correct, but that might also be due to me casting a parameter in a wrong way. I'll let you know once i found out.

EDIT: Pretty sure it was an error on my end.

@leifniem
Copy link
Contributor Author

leifniem commented Jun 2, 2023

Sorry, code from my project appeared here because i used my fork as a submodule, i will clean it up when i get the time

@leifniem
Copy link
Contributor Author

leifniem commented Jun 2, 2023

@adelsz removed everything i accidentally had in the repo. it's down to one file now :)

@KhaledElmorsy
Copy link

Hope this gets merged soon.

@leifniem
Copy link
Contributor Author

Since the dev is located in Ukraine i totally understand if it's still open for a while.

@adelsz
Copy link
Owner

adelsz commented Sep 24, 2023

Thanks @leifniem!

@adelsz adelsz merged commit 1a518d2 into adelsz:master Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants