fix: conditional modifiers not working as expected #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoisadam
requested review from
soulcramer,
SimonMarquis and
a team
as code owners
SimonMarquis
approved these changes
Jan 28, 2025
soulcramer
pushed a commit
that referenced
this pull request
Jan 29, 2025
Co-authored-by: Francois ADAM <[email protected]> Co-authored-by: spark-ui-bot <[email protected]> (cherry picked from commit 217bccd) Signed-off-by: Scott Rayapoullé <[email protected]>
soulcramer
added a commit
that referenced
this pull request
Jan 29, 2025
Signed-off-by: Scott Rayapoullé <[email protected]> Co-authored-by: francoisadam <[email protected]> Co-authored-by: Francois ADAM <[email protected]> Co-authored-by: spark-ui-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
Fix the conditional modifier extensions
🤔 Context
The conditional modifiers seem to drop previous modifiers in case the condition is not met.
After further investigation, it appears that if the condition is not met, the extension returns Modifier instead of this, hence this issue.