feat: update rating specs #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # catalog/src/main/kotlin/com/adevinta/spark/catalog/model/Components.kt # gradle/libs.versions.toml # spark/dependencies/releaseRuntimeClasspath.txt
soulcramer
requested review from
SimonMarquis,
kazaky and
a team
as code owners
spark/src/main/kotlin/com/adevinta/spark/components/rating/RatingLong.kt
Outdated
Show resolved
Hide resolved
spark/src/main/kotlin/com/adevinta/spark/components/rating/RatingLong.kt
Outdated
Show resolved
Hide resolved
spark/src/main/kotlin/com/adevinta/spark/components/rating/RatingSmall.kt
Outdated
Show resolved
Hide resolved
spark/src/test/kotlin/com/adevinta/spark/rating/RatingStarStateTest.kt
Outdated
Show resolved
Hide resolved
spark/src/test/kotlin/com/adevinta/spark/rating/RatingStarStateTest.kt
Outdated
Show resolved
Hide resolved
| import kotlin.test.assertEquals | ||
|
|
||
| @RunWith(TestParameterInjector::class) | ||
| class RatingStarStateTest { |
There was a problem hiding this comment.
Is this our first unit-test? 🙌
There was a problem hiding this comment.
Yes! I plan to re-add the one we had for the button progress and one for the tag traversalGrouping 👍
|
🚨 UI regression detected! Checkout the paparazzi-delta artifact.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
Change the specs from Brikke to Spark and Polaris as it was based on Brikke specs.
This mean that we will temporary provide the Polaris component from Spark to not break consumers in this update
🤔 Context
Close #807
✅ Checklist
📸 Screenshots