Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add examples ad configurator for Rating Display #822

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

soulcramer
Copy link
Contributor

πŸ“‹ Changes

Add examples for all type of ratings (Spark & Polaris) and a configurator for Rating display values and sizes

πŸ€” Context

Close #817
Close #818

βœ… Checklist

  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.

πŸ“Έ Screenshots

@soulcramer soulcramer added CatalogApp Related to the demo app Component Related to a component labels Nov 22, 2023
@soulcramer soulcramer self-assigned this Nov 22, 2023
@soulcramer soulcramer requested review from SimonMarquis, kazaky and a team as code owners November 22, 2023 16:52
@soulcramer soulcramer marked this pull request as draft November 22, 2023 16:53
@soulcramer soulcramer changed the base branch from main to rating November 22, 2023 16:54
@soulcramer soulcramer force-pushed the rating-examples branch 3 times, most recently from d976be8 to 574fd4c Compare December 8, 2023 08:36
Base automatically changed from rating to main December 12, 2023 09:03
@soulcramer soulcramer marked this pull request as ready for review December 12, 2023 09:11
# Conflicts:
#	spark/src/main/kotlin/com/adevinta/spark/components/rating/RatingStar.kt
Copy link

@kazaky kazaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soulcramer soulcramer added this pull request to the merge queue Dec 12, 2023
@soulcramer soulcramer removed this pull request from the merge queue due to a manual request Dec 12, 2023
@soulcramer soulcramer merged commit f4a26da into main Dec 12, 2023
5 checks passed
@soulcramer soulcramer deleted the rating-examples branch December 12, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CatalogApp Related to the demo app Component Related to a component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rating] Create Configurator [Rating] Create Examples
2 participants