Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Enhance Popover screenshot test #890

Merged
merged 9 commits into from
Jan 15, 2024
Merged

fix: Enhance Popover screenshot test #890

merged 9 commits into from
Jan 15, 2024

Conversation

kazaky
Copy link

@kazaky kazaky commented Jan 11, 2024 •
edited
Loading

📋 Changes

  • Enhance the way we take screenshots for Popover
  • Add a minor change requested by designers for popover dismiss button

🤔 Context

✅ Checklist

  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • If it includes design changes, please ask for a review spark-design GitHub team.

📸 Screenshots

🗒️ Other info

@kazaky kazaky marked this pull request as ready for review January 11, 2024 10:43
@kazaky kazaky requested review from soulcramer, SimonMarquis and a team as code owners January 11, 2024 10:43
@github-actions GitHub Actions
Copy link
Contributor

🔣 PR title format

commit validation: failed!
please enter a commit message in the commitizen format.
commit "": "Fix: Fix failing test in main branch"
pattern: (?s)(build|ci|docs|feat|fix|perf|refactor|style|test|chore|revert|bump)(\(\S+\))?!?:( [^\n\r]+)((\n\n.*)|(\s*))?$

@kazaky kazaky changed the title Fix: Fix failing test in main branch fix: fix failing test in main branch Jan 11, 2024
@kazaky kazaky marked this pull request as draft January 11, 2024 11:07
@kazaky kazaky marked this pull request as ready for review January 11, 2024 11:25
@kazaky
Copy link
Author

kazaky commented Jan 11, 2024

@spark-ui-bot paparazzi golden images

@kazaky kazaky changed the title fix: fix failing test in main branch fix: Enhance Popover screenshot test Jan 11, 2024
@kazaky kazaky added this pull request to the merge queue Jan 15, 2024
Merged via the queue into main with commit 7926883 Jan 15, 2024
5 checks passed
@kazaky kazaky deleted the fix_failing_test_in_main branch January 15, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soulcramer soulcramer soulcramer approved these changes

@SimonMarquis SimonMarquis Awaiting requested review from SimonMarquis SimonMarquis is a code owner

Assignees

@kazaky kazaky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kazaky @soulcramer @spark-ui-bot