Allow to bypass Hostname DNS check #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@manelmontilla : Any progress on getting this merged? Let me know if there are any work that I can do to help out unblocking this. |
added 5 commits
April 24, 2024 11:20
…e performed with a dns resolution or not
…tion, and instead use the viper library for that
…iguration items into the Vulcanito struct
jesusfcr
force-pushed
the
alexanderkjall-add-check-val-pr
branch
from
e18318e to
35501ec
Compare
jesusfcr
force-pushed
the
alexanderkjall-add-check-val-pr
branch
from
54d1e7c to
8a93de5
Compare
jesusfcr
force-pushed
the
alexanderkjall-add-check-val-pr
branch
from
8a93de5 to
87e3736
Compare
jesusfcr
changed the title
danfaizer
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr allows to configure vulcan-api to not validate hostnames DNS names.
This doesn't change the detect process to infer the assettype from an asset.