add a hostname verification function that doesn't do dns resolution #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manelmontilla
requested changes
Feb 23, 2024
types.go
Outdated
| @@ -215,6 +215,21 @@ func IsHostname(target string) bool { | |||
| return len(r) > 0 | |||
| } | |||
|
|
|||
| // IsHostnameNoDnsResolution returns true if the target is not an IP. | |||
| func IsHostnameNoDnsResolution(target string) bool { | |||
There was a problem hiding this comment.
I would do: s/Dns/DNS in the name of the function.
types_test.go
Outdated
| @@ -628,6 +628,45 @@ func TestIsHostname(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestIsHostnameNoDnsResolution(t *testing.T) { | |||
There was a problem hiding this comment.
I would do: s/Dns/DNS in the name of the function.
|
@manelmontilla Any chance on getting this reviewed? |
|
@manelmontilla : Is there anything we can do to help get this merged? |
|
Hi @kozmic, |
alexanderkjall
force-pushed
the
check-hostname-without-dns-resolution
branch
from
cb055d0 to
868061d
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a hostname check that doesn't do a dns verification of the hostname, in order to support the use case of tracking assets that are behind a split horizon dns setup.
This is part 1 of 2, the other part will be in vulcan-api and use this function.