Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON schemes preparations for first official release #87

Merged
merged 10 commits into from
Mar 23, 2020
Merged

JSON schemes preparations for first official release #87

merged 10 commits into from
Mar 23, 2020

Conversation

ahokkonen
Copy link
Contributor

@ahokkonen ahokkonen commented Mar 21, 2020 •
edited
Loading

  • location/breed/animal/trait identifiers updated to use inheritance
  • exampleUrlScheme path responses fixed to use collection instead of array of collection
  • exampleUrlScheme response names renamed to collections
  • added empty member -property into icarResourceCollection.json
  • added type definition into all main base resources
  • @id in icarResource renamed to @self due code generation issues
  • fixed "numeric" types with "integer" format into "integer" type (aligned with OpenAPI 3 specs)
  • exampleUrlScheme tags renamed to release-candidate =>ADE-1 (Speccy validation throws error because of rule "openapi object should have alphabetical tags")
  • JSON schema updated to always use relative resource reference paths
  • JSON schema files updated to use 2 spaces indents instead 4 or 8

#80
#84

Anton Hokkonen added 7 commits March 20, 2020 16:34
JSON formatting alignment
ab3629c 
- updates JSON files to use 2 spaces indents instead 4 or 8
Schemes refactoring
68829f0 
- updated schemes to always use relative resource reference paths
Url scheme updated
d6bec0f 
- fixed path responses to use collection instead of array of collection
- updated response names to collections
- updated tags to RC->ADE-1
Identifiers updated
2629308 
- location/breed/animal/trait identifiers updated to use inheritance
Resource collection updated
b66e5c8 
- added empy member -property
- added discriminator for generic array support
Fixes declaration for numeric types
a5563b1 
- fixed "numeric" types with "integer" format into "integer" type
Added "*Type" discriminator into base resources
b4ddf8a 
- added type definition into all main base resources
- @id in icarResource renamed to @self due code generation issues
@ahokkonen ahokkonen changed the title JSON schema preparations for first official release JSON schemes preparations for first official release Mar 21, 2020
@cookeac
Copy link
Collaborator

cookeac commented Mar 22, 2020

@ahokkonen I don't have time today, so could you please merge the lactation API from Erwin's latest PR (now merged) into your version of exampleUrlScheme.json, and then I think we will be ok to merge this.

@ahokkonen ahokkonen closed this Mar 23, 2020
@ahokkonen ahokkonen reopened this Mar 23, 2020
@ahokkonen
Copy link
Contributor Author

Added new commits:

  • lactation merge and minor fixes to it
  • scheme alignment to follow OpenAPI 3 specs (moved "object" declaration inside allOf for inherited resources)

@cookeac cookeac merged commit 0bf322f into adewg:master Mar 23, 2020
@ahokkonen ahokkonen mentioned this pull request Mar 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahokkonen @cookeac