Initial commit #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still to do (now or in later iterations)
|
|
If you want to test this:
|
|
There is also a file file adhese_test.go which run the jsons in adapters/adhese/adhesetest/ |
|
OK |
mefjush
reviewed
Apr 15, 2020
| AdDuration5th string `json:"adDuration5th"` | ||
| AdDuration6th string `json:"adDuration6th"` | ||
| Width3rd string `json:"width3rd"` | ||
| Width4th string `json:"width4th"` |
There was a problem hiding this comment.
do we really need to expose that kind of fields? what for?
mefjush
reviewed
Apr 15, 2020
| Extension Prebid `json:"extension"` | ||
| } | ||
|
|
||
| type AdheseAdditionalCreative struct { |
There was a problem hiding this comment.
the same goes for this - how is it supposed to be used in prebid context?
mefjush
pushed a commit
that referenced
this pull request
Apr 23, 2021
* Pubstack Analytics V1 (#11) * V1 Pubstack (#7) * feat: Add Pubstack Logger (#6) * first version of pubstack analytics * bypass viperconfig * commit #1 * gofmt * update configuration and make the tests pass * add readme on how to configure the adapter and update the network calls * update logging and fix intake url definition * feat: Pubstack Analytics Connector * fixing go mod * fix: bad behaviour on appending path to auction url * add buffering * support bootstyrap like configuration * implement route for all the objects * supports termination signal handling for goroutines * move readme to the correct location * wording * enable configuration reload + add tests * fix logs messages * fix tests * fix log line * conclude merge * merge * update go mod Co-authored-by: Amaury Ravanel <[email protected]> * fix duplicated channel keys Co-authored-by: Amaury Ravanel <[email protected]> * first pass - PR reviews * rename channel* -> eventChannel * dead code * Review (#10) * use json.Decoder * update documentation * use nil instead []byte("") * clean code * do not use http.DefaultClient * fix race condition (need validation) * separate the sender and buffer logics * refactor the default configuration * remove error counter * Review GP + AR * updating default config * add more logs * remove alias fields in json * fix json serializer * close event channels Co-authored-by: Amaury Ravanel <[email protected]> * fix race condition * first pass (pr reviews) * refactor: store enabled modules into a dedicated struct * stop goroutine * test: improve coverage * PR Review * Revert "refactor: store enabled modules into a dedicated struct" This reverts commit f57d9d6. # Conflicts: # analytics/config/config_test.go Co-authored-by: Amaury Ravanel <[email protected]>
mefjush
pushed a commit
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.