[pull] master from prebid:master #13
Conversation
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Co-authored-by: Chris Corbo <[email protected]>
Co-authored-by: qt-io <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // As a fallback, guess markup type based on requested type - AdTonos is an audio company so we prioritize that. | ||
| for _, requestImp := range requestImps { | ||
| if requestImp.ID == bid.ImpID { | ||
| if requestImp.Audio != nil { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeAudio, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
| if requestImp.ID == bid.ImpID { | ||
| if requestImp.Audio != nil { | ||
| return openrtb_ext.BidTypeAudio, nil | ||
| } else if requestImp.Video != nil { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeVideo, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
Co-authored-by: apykhteyev <[email protected]>
Co-authored-by: Shriprasad Marathe <[email protected]> Co-authored-by: ashish.shinde <[email protected]> Co-authored-by: dhruv.sonone <[email protected]>
Co-authored-by: apykhteyev <[email protected]>
authored by @dkornet-ad
Co-authored-by: bansawbanchee <[email protected]>
Co-authored-by: oleksandr <[email protected]>
Co-authored-by: oleksandr <[email protected]>
Co-authored-by: harribey <[email protected]>
Co-authored-by: ddubyk <[email protected]>
Co-authored-by: Shahaf Sameach <[email protected]> Co-authored-by: Idan Botbol <[email protected]>
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )