Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes on testing, remove --runInBand #134

Merged
merged 10 commits into from
Feb 3, 2021
Merged

Conversation

dcloud
Copy link
Collaborator

@dcloud dcloud commented Jan 28, 2021

Description of change

How to test

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

@dcloud dcloud changed the title Remove --runInBand Add notes on testing, remove --runInBand Feb 1, 2021
@dcloud dcloud marked this pull request as ready for review February 1, 2021 16:13
@dcloud
Copy link
Collaborator Author

dcloud commented Feb 1, 2021

This is a light PR with some notes and minor changes, since the cause of backend tests failures was already addressed.

I also have a branch with some complex changes that I would like to run by the team.

Copy link

@jasalisbury jasalisbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Looks good! Just one question about the example Promise.all usage!

docs/testing.md Outdated
Here's how that might look:

```
let a = await someAsyncFun();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this example wouldn't await someAsyncFun(); wait for the resulting someAsyncFunc promise to resolve? This would mean a is not a promise but the resolved value of the promise? Should this be let a = someAsyncFunc()?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, yup. I was going to write a before/after example, and then did neither. Good catch

Copy link

@jasalisbury jasalisbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@kryswisnaskas kryswisnaskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dcloud dcloud requested a review from kryswisnaskas February 2, 2021 20:17
@dcloud
Copy link
Collaborator Author

dcloud commented Feb 2, 2021

After looking into some issues with @dcmcand, we added some changes that mitigate errors arising from tests deleting more database records than they create. I also added a section on that into the docs/testing.md.

cc @kryswisnaskas

@dcloud dcloud merged commit 9e05993 into main Feb 3, 2021
@dcloud dcloud deleted the dcloud/test-failure-fixes branch February 3, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants