-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notes on testing, remove --runInBand #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Looks good! Just one question about the example Promise.all
usage!
docs/testing.md
Outdated
Here's how that might look: | ||
|
||
``` | ||
let a = await someAsyncFun(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this example wouldn't await someAsyncFun();
wait for the resulting someAsyncFunc
promise to resolve? This would mean a
is not a promise but the resolved value of the promise? Should this be let a = someAsyncFunc()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, yup. I was going to write a before/after example, and then did neither. Good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
After looking into some issues with @dcmcand, we added some changes that mitigate errors arising from tests deleting more database records than they create. I also added a section on that into the |
Description of change
How to test
Issue(s)
Checklist