Fix region order and add non-grantees. #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kryswisnaskas
requested review from
AdamAdHocTeam,
dcloud,
SarahJaine and
thewatermethod
thewatermethod
approved these changes
Jun 21, 2021
…into kw-fix-region-order
thewatermethod
approved these changes
Jun 24, 2021
| @@ -9,8 +9,7 @@ | |||
| } | |||
|
|
|||
| .smart-hub--overview-data { | |||
| margin-left: -20px; | |||
| margin-bottom: -20px; | |||
| margin-left: -36px !important; | |||
There was a problem hiding this comment.
is there a way to be more specific without !important?
There was a problem hiding this comment.
I found that this was the only way I could get that to work. Not ideal, since !important is a last resort technique. Perhaps once the layout changes, e.g. with addition of the welcome we could revisit.
| expect(activityRecipientsAfter.length).toBe(5); | ||
| expect(activityRecipientsAfter[2].nonGranteeId).toBe(3); | ||
| }); | ||
| it('is idempotent', async () => { |
There was a problem hiding this comment.
learned a new word
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Follow-up PR to the TTA overview widget. Fixes region order in the region select dropdown. Adds non-grantees to the widget and combines duration into one item. Additionally, it includes the legacy reports in statistics and limits the reports to approved ones.
How to test
https://tta-smarthub-sandbox.app.cloud.gov/activity-reportsThis can also be tested locally.
Issue(s)
Checklists
Every PR
Production Deploy
After merge/deploy