Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in programs from HSES nightly download #464

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

jasalisbury
Copy link

Description of change

Adds a new database table called "Programs". Each grant can have zero or more programs. With this data in the DB we can display the program abbreviations for each grant (HS, EHS, etc) that are required for the grantee page.

How to test

Verify tests pass

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

Copy link
Collaborator

@thewatermethod thewatermethod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, all tests pass.

Just curious - why create a new table vs just adding the "program type" column to grants?

@jasalisbury
Copy link
Author

Looks good, all tests pass.

Just curious - why create a new table vs just adding the "program type" column to grants?

There is a lot of information other then programType that I imagine we will want to use in the future. Seems like there is even more info not currently in the download we can ask HSES to add for us.

@jasalisbury jasalisbury merged commit 07bdbcb into main Oct 11, 2021
@jasalisbury jasalisbury deleted the js-336-add-programs-to-hses-download branch October 11, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants