-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TTTA-HUB 22: Add User Permission to Unlock Approved Reports #478
Conversation
I understand it might be out of scope of this PR to handle all the accessibility issues with our modals, but I would at least like to see
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few minor things
Playing with USWDS modals here, the focus is trapped inside the modal and the modal closes when I click out. This makes me wonder, 1) Are we using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only have one comment. Also can you add the new route to the API documentation at docs/openapi
?
This has been updated. |
Description of change
Added new global param to allow select users to UNLOCK approved reports.
How to test
Enable the new UNLOCK global user param on your user. Then create a new report and approve. When viewing the approved report you should now see the UNLOCK button. Clicking this button and agreeing to unlock should set the report and all approvers back to a NEEDS_ACTION state.
Issue(s)
Checklists
Every PR
- [ ] API Documentation updated- [ ] Boundary diagram updated- [ ] Logical Data Model updated- [ ] Architectural Decision Records written for major infrastructure decisionsProduction Deploy
- [ ] Staging smoke test completedAfter merge/deploy