Skip to content

Commit

Permalink
backupccl: enable restore_span.target_size
Browse files Browse the repository at this point in the history
This setting was previously disabled because of timeouts being
observed when restoring our TPCCInc fixtures. The cause of those
timeouts has been identified as
cockroachdb#88329 making it safe
to re-enable merging of spans during restore. This settings prevents
restore from over-splitting and leaving the cluster with a merge hangover
post restore.

Informs: cockroachdb#86470

Release note (sql change): Sets `backup.restore_span.target_size`
to default to 384 MiB so that restore merges upto that size of spans
when reading from the backup before actually ingesting data. This should
reduce the number of ranges created during restore and thereby reduce
the merging of ranges that needs to occur post restore.
  • Loading branch information
adityamaru committed Oct 4, 2022
1 parent 54e81fc commit 132e195
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/ccl/backupccl/restore_span_covering.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ var targetRestoreSpanSize = settings.RegisterByteSizeSetting(
settings.TenantWritable,
"backup.restore_span.target_size",
"target size to which base spans of a restore are merged to produce a restore span (0 disables)",
0, //TODO(dt): make this something like 384 << 20,
384<<20,
)

// makeSimpleImportSpans partitions the spans of requiredSpans into a covering
Expand Down

0 comments on commit 132e195

Please sign in to comment.